cli: Add consul intention list command (based on PR #6825)#9468
cli: Add consul intention list command (based on PR #6825)#9468hanshasselberg merged 8 commits intohashicorp:masterfrom karras:feature_intention_list
Conversation
karras
changed the title
|
Please let me know if I have to do something to make the |
| } | ||
|
|
||
| result := make([]string, 0, len(ixns)) | ||
| header := "ID|Source|Action|Destination|Precedence" |
There was a problem hiding this comment.
Please use \x1f as the delimiter. See #6652 for more details.
There was a problem hiding this comment.
Done! I've quickly tested it in my Enterprise environment and it seems to look fine but may I ask you to do a short cross check?
hanshasselberg
left a comment
hanshasselberg
left a comment
There was a problem hiding this comment.
LGTM, except the delimiter.
|
One more thing: could you add a file in |
Done, let me know if it needs to be adjusted. :) |
hanshasselberg
left a comment
hanshasselberg
left a comment
There was a problem hiding this comment.
Thank you for the changes!
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/309042. |
|
🍒✅ Cherry pick of commit 3c3b672 onto |
This PR is based on the previous work by @snuggie12 in PR #6825. It adds the command consul intention list to list all available intentions. The list functionality for intentions seems a bit overdue as it's just very handy. The web UI cannot list intentions outside of the default namespace, and using the API is sometimes not the friendliest option. ;) I cherry picked snuggie12's commits who did most of the heavy lifting (thanks again @snuggie12 for your great work!). The changes in the original commit mostly still worked on the current HEAD. On top of that I added support for namespaces and fixed the docs as they are managed differently today. Also the requested changes related to the "Connect" references in the original PRs have been addressed. Fixes #5652 Co-authored-by: Matt Hoey <[email protected]>
|
🍒✅ Cherry pick of commit 3c3b672 onto |
This PR is based on the previous work by @snuggie12 in PR #6825. It adds the command consul intention list to list all available intentions. The list functionality for intentions seems a bit overdue as it's just very handy. The web UI cannot list intentions outside of the default namespace, and using the API is sometimes not the friendliest option. ;) I cherry picked snuggie12's commits who did most of the heavy lifting (thanks again @snuggie12 for your great work!). The changes in the original commit mostly still worked on the current HEAD. On top of that I added support for namespaces and fixed the docs as they are managed differently today. Also the requested changes related to the "Connect" references in the original PRs have been addressed. Fixes #5652 Co-authored-by: Matt Hoey <[email protected]>
4 participants
This PR is based on the previous work by @snuggie12 in PR #6825. It adds the command
consul intention listto list all available intentions. Thelistfunctionality for intentions seems a bit overdue as it's just very handy. The web UI cannot list intentions outside of thedefaultnamespace, and using the API is sometimes not the friendliest option. ;)I cherry picked snuggie12's commits who did most of the heavy lifting (thanks again @snuggie12 for your great work!). The changes in the original commit mostly still worked on the current
HEAD. On top of that I added support for namespaces and fixed the docs as they are managed differently today. Also the requested changes related to the "Connect" references in the original PRs have been addressed.Fixes #5652